8000 fix PropType by sapphi-red · Pull Request #446 · vuejs/composition-api · GitHub
[go: up one dir, main page]
Skip to content

fix PropType #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2020
Merged

fix PropType #446

merged 2 commits into from
Jul 20, 2020

Conversation

sapphi-red
Copy link
Contributor
@sapphi-red sapphi-red commented Jul 20, 2020 •
edited
Loading

Fixed prop types becoming any or undefined.

  • Reverted fix(type): fix tying issues in #428 #444 because it changed some types of prop to any type
  • Added tests to check whether it is not any type
  • Fixed Function not to be undefined now it becomes Function
  • Added tests to check whether it is not undefined type (of course it allows optional types)

@antfu
Copy link
Member
antfu commented Jul 20, 2020

My bad, thanks!

@antfu antfu merged commit 7aa25ee into vuejs:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @antfu
0