refactor: rename createComponent as defineComponent #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Jan 17, 2020
16aed1b to
666db95
Compare
|
@posva 👍 I pushed a fixup commit introducing retro-compat and a warning in dev mode. Let me know what you think. |
|
Could you please fix the merge conflicts to reflect the changes added in #189? |
|
@sodatea I merged master into the branch. I used |
a91c945 to
c236f4f
Compare
Since Vue `3.0.0-alpha.1`, `createComponent` has been renamed `defineComponent`. See vuejs/core@1c4cdd8
c236f4f to
3ce8533
Compare
|
@posva I properly rebased to squash my extra fixup commit and solve the conflict, using |
haoqunjiang
approved these changes
Feb 18, 2020
pikax
pushed a commit
to pikax/vue-function-api
that referenced
this pull request
Apr 19, 2020
Since Vue `3.0.0-alpha.1`, `createComponent` has been renamed `defineComponent`. See vuejs/core@1c4cdd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Vue
3.0.0-alpha.1,createComponenthas been renameddefineComponent.See vuejs/core@1c4cdd8