8000 refactor: rename createComponent as defineComponent by cexbrayat · Pull Request #230 · vuejs/composition-api · GitHub
[go: up one dir, main page]
Skip to content

refactor: rename createComponent as defineComponent #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

refactor: rename createComponent as defineComponent #230

merged 1 commit into from
Feb 18, 2020

Conversation

cexbrayat
Copy link
Member

Since Vue 3.0.0-alpha.1, createComponent has been renamed defineComponent.
See vuejs/core@1c4cdd8

posva
posva requested changes Jan 17, 2020
View reviewed changes
Copy link
Member
@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to keep a createComponent function that shows a message saying the method is now named defineComponent to allow people upgrading without breaking their existing code

@cexbrayat cexbrayat force-pushed the refactor/define-component branch from 16aed1b to 666db95 Compare January 17, 2020 12:55
@cexbrayat
Copy link
Member Author

@posva 👍 I pushed a fixup commit introducing retro-compat and a warning in dev mode. Let me know what you think.

posva
posva reviewed Jan 17, 2020
View reviewed changes
Copy link
Member
@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

ping @liximomo

@haoqunjiang
Copy link
Member

Could you please fix the merge conflicts to reflect the changes added in #189?

@posva
Copy link
Member
posva commented Feb 17, 2020

@sodatea I merged master into the branch. I used unknown instead of any

@cexbrayat cexbrayat force-pushed the refactor/define-component branch from a91c945 to c236f4f Compare February 17, 2020 10:34
@cexbrayat
refactor: rename createComponent as defineComponent
3ce8533 
Since Vue `3.0.0-alpha.1`, `createComponent` has been renamed `defineComponent`.
See vuejs/core@1c4cdd8
@cexbrayat cexbrayat force-pushed the refactor/define-component branch from c236f4f to 3ce8533 Compare February 17, 2020 10:37
@cexbrayat
Copy link
Member Author

@posva I properly rebased to squash my extra fixup commit and solve the conflict, using unknown

@haoqunjiang haoqunjiang merged commit 3463fbc into vuejs:master Feb 18, 2020
pikax pushed a commit to pikax/vue-function-api that referenced this pull request Apr 19, 2020
@cexbrayat @pikax
refactor: rename createComponent as defineComponent (vuejs#230)
497b7e5 
Since Vue `3.0.0-alpha.1`, `createComponent` has been renamed `defineComponent`.
See vuejs/core@1c4cdd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cexbrayat @haoqunjiang @posva
0