8000 fix[Select|Cascader]: select multiple error & cascader error in ssr mode by cc-hearts · Pull Request #7377 · vueComponent/ant-design-vue · GitHub
[go: up one dir, main page]
Skip to content

fix[Select|Cascader]: select multiple error & cascader error in ssr mode #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2024
Merged

fix[Select|Cascader]: select multiple error & cascader error in ssr mode #7377

merged 4 commits into from
Apr 19, 2024

Conversation

cc-hearts
Copy link
Contributor

close #7362
close #7321

@cc-hearts
Copy link
Contributor Author

这样做性能可能会有所损耗🤔

@cc-hearts cc-hearts changed the title Fix/ select multiple error & cascader error in ssr mode fix[Select|Cascader]: select multiple error & cascader error in ssr mode Feb 23, 2024
@cc-hearts cc-hearts marked this pull request as ready for review February 23, 2024 13:20
@YvesChen
Copy link
YvesChen commented Mar 5, 2024

bug挺致命的，请问题主解决了吗，😢有解决方案吗？
image

@wsxe9988
Copy link
wsxe9988 commented Mar 5, 2024

bug挺致命的，请问题主解决了吗，😢有解决方案吗？ image

用的什么版本的

@aibayanyu20
Copy link
Member

这个问题或许应该在icons里面处理

@cc-hearts
Copy link
Contributor Author

问题应该不在于 icon 是 过早初始化了插槽的值，之后每一个 option 都使用了相同的 vnode 导致了渲染错误了。
（vue 的文档也标注了 VNode 必须唯一）
953365a80e60aac448028b5e3994c807

@cc-hearts
Copy link
Contributor Author

🤔 目前cloneVNode 是我能想到影响最小的修复方案了

@shenqidedaizi-foxmail
Copy link

这个问题现在还存在

@tangjinzhou
Copy link
Member

怎么感觉有挺多地方有这些隐患的呢

@tangjinzhou tangjinzhou merged commit c28c38d into vueComponent:main Apr 19, 2024
tangjinzhou added a commit that referenced this pull request Apr 22, 2024
@tangjinzhou
fix: select customicon error #7377
23c620e
@cc-hearts cc-hearts deleted the fix/ssr-select-multiple-error branch May 30, 2024 03:20
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nuxt3中使用select多选框，点击选项有js报错 cascader 组件在 nuxt 中使用 vue 3.4.8 及以上的版本时, 无法正常使用
6 participants
@cc-hearts @YvesChen @wsxe9988 @aibayanyu20 @shenqidedaizi-foxmail @tangjinzhou
0