8000 fix: docgen should not try to resolve files put of validExtends by elevatebart · Pull Request #1672 · vue-styleguidist/vue-styleguidist · GitHub
[go: up one dir, main page]
Skip to content

fix: docgen should not try to resolve files put of validExtends #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 8, 2024
Merged

fix: docgen should not try to resolve files put of validExtends #1672

merged 10 commits into from
Jul 8, 2024

Conversation

elevatebart
Copy link
Member

closes #1653

@elevatebart elevatebart linked an issue Jun 30, 2024 that may be closed by this pull request
Docgen fails to resolve radix-vue module #1653
Closed
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: aecc277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vue-docgen-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@what-the-diff What The Diff
Copy link
what-the-diff bot commented Jun 30, 2024

PR Summary

  • Updated .changeset/curly-bulldogs-shout.md with vue-docgen-api patch
    This file was added, including a fix for a bug related to how we parse Props in our macro functions. This was purely a bug fix meaning it didn't include any significant updates or potential breaking changes.

  • Renamed dirty-horses-glow.md
    The file formerly known as dirty-horses-glow.md in the vue-docgen-api package has a new name: .changeset/dirty-horses-glow.md.

  • Added .changeset/pretty-squids-fail.md with vue-docgen-api patch
    This file was added. A key update in this change was the fact that we are now considering validExtends in our TypeScript resolution.

  • Updated .gitignore and turbo.json
    We shifted .turbo to the gitignore list. Moreover, turbo.json now has new dependencies for tsconfig.json and the compile task has gained a few additional inputs and outputs.

  • Updated package.json
    Several updates were made to this file, including the project name which is now "vue-styleguidist". Additionally, we updated the turbo package version to ^2.0.6 and shifted to using pnpm@8.15.3 as our package manager.

  • Removed .changeset/README.md and .changeset/config.json
    These two files from the vue-docgen-api package have been removed in this PR.

  • Updated tsUtils.ts
    A check for validExtends was introduced.

  • Changed project name in vue-styleguidist/package.json
    The project's name has been altered to "vue-styleguidist-vue-styleguidist".

These updates aim to improve the overall functionality and adaptability of our system, while maintaining the ease of use for developers.

@socket-security Socket Security
Copy link
socket-security bot commented Jun 30, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@elevatebart elevatebart changed the title fix: docgen should not. try to resolve files put of validExtends fix: docgen should not try to resolve files put of validExtends Jul 1, 2024
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/parser@7.24.7 None 0 1.89 MB nicolo-ribaudo
npm/lodash@4.17.21 None 0 1.41 MB bnjmnt4n
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/source-map@0.6.1 None 0 805 kB tromey

🚮 Removed packages: npm/babel-helper-vue-jsx-merge-props@2.0.3

View full report↗︎

@cypress Cypress
Copy link
cypress bot commented Jul 8, 2024

Passing run #662 ↗︎

0 57 0 0 Flakiness 0

Details:

Merge branch 'dev' into 1653-docgen-fails-to-resolve-radix-vue-module
Project: vue-styleguidist Commit: aecc2776b8
Status: Passed Duration: 16:56 💡
Started: Jul 8, 2024 9:54 AM Ended: Jul 8, 2024 10:11 AM

Review all test suite changes for PR #1672 ↗︎

@elevatebart elevatebart merged commit dd8bdd1 into dev Jul 8, 2024
@elevatebart elevatebart deleted the 1653-docgen-fails-to-resolve-radix-vue-module branch July 8, 2024 10:29
@elevatebart elevatebart mentioned this pull request Jul 8, 2024
Merged
elevatebart added a commit that referenced this pull request Jul 8, 2024
@elevatebart @github-actions
ci(changesets): version packages (#1676)
cc30b72 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to dev, this PR will
be updated.


# Releases
## vue-docgen-api@4.79.1

### Patch Changes

-
[#1672](#1672)
[`dd8bdd19`](dd8bdd1)
Thanks [@elevatebart](https://github.com/elevatebart)! - - Failed to
parse the Props passed to Macro function as Type alias reference,

i had a bug on Storybook because of this and the problem it not throwing
any exception so hard to detected the origin of bug. No breaking changes
it will work properly once consumer update his version

-
[#1672](#1672)
[`dd8bdd19`](dd8bdd1)
Thanks [@elevatebart](https://github.com/elevatebart)! - export-all
should not skip all extensions

-
[#1672](#1672)
[`dd8bdd19`](dd8bdd1)
Thanks [@elevatebart](https://github.com/elevatebart)! - take
validExtends into account for typescript reolution too

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docgen fails to resolve radix-vue module

1 participant

@elevatebart
0