8000 chore: compile with C++ 20 by 0ax1 · Pull Request #6889 · vortex-data/vortex · GitHub
[go: up one dir, main page]

Skip to content

chore: compile with C++ 20#6889

Merged
0ax1 merged 1 commit intodevelopfrom
ad/c++20
Mar 11, 2026
Merged

chore: compile with C++ 20#6889
0ax1 merged 1 commit intodevelopfrom
ad/c++20

Conversation

@0ax1
Copy link
Contributor
@0ax1 0ax1 commented Mar 11, 2026

We can switch to C++20 as the latest DuckDB Docker image to build extensions now supports it: https://github.com/vortex-data/duckdb-vortex/actions/runs/22958627873/job/66642571037?pr=76

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from myrrc March 11, 2026 15:17
@0ax1 0ax1 added chore changelog/chore A trivial change and removed chore labels Mar 11, 2026
@0ax1 0ax1 enabled auto-merge (squash) March 11, 2026 15:20
@codspeed-hq
Copy link
codspeed-hq bot commented Mar 11, 2026

Merging this PR will improve performance by 11.36%

⚡ 1 improved benchmark
✅ 1028 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%

Comparing ad/c++20 (aea2b78) with develop (9c051ae)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 merged commit c3d57a1 into develop Mar 11, 2026
59 of 62 checks passed
@0ax1 0ax1 deleted the ad/c++20 branch March 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0