Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
|
What's the justification? |
Contributor
Author
|
The vtable docs says so 😀 Real reason, is that this allows both the type erased and typed versions to defef to the same &Foo, which make a lot of APIs a lot simpler. The cost is that &Foo is more expensive to clone since there is no arc. However any function that could require returning "self" should be implemented over the type erased version FooRef and the typed vtable should return Option. Therefore the clone is always performed over the erased version which contains an Arc. |
robert3005
approved these changes
Mar 11, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.