Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
gatesn
reviewed
Mar 10, 2026
| /// in the TemporalMetadata. | ||
| pub fn temporal_values(&self) -> &ArrayRef { | ||
| self.ext.storage() | ||
| self.ext.storage_array() |
Contributor
There was a problem hiding this comment.
I'd rather not just break the API without some reason other than naming
Contributor
Author
There was a problem hiding this comment.
Since we now have storage dtypes, storage scalars, and storage arrays, we need to specify what it is (especially on the ExtensionArray where this could easily mean both the storage dtype or the storage array
gatesn
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds some missing constructors to
ExtensionArraythat we will want soon, as well as renamesstoragetostorage_array.API Changes
The API changes are minimal, and nobody should really be using them anyways right now.
Testing
N/A