8000 Engine specific SLT by AdamGS · Pull Request #6822 · vortex-data/vortex · GitHub
[go: up one dir, main page]

Skip to content

Engine specific SLT#6822

Merged
AdamGS merged 2 commits intodevelopfrom
adamg/engine-specific-slt
Mar 6, 2026
Merged

Engine specific SLT#6822
AdamGS merged 2 commits intodevelopfrom
adamg/engine-specific-slt

Conversation

@AdamGS
Copy link
Contributor
@AdamGS AdamGS commented Mar 6, 2026

Allows writing engine-specific SLT tests, by putting them in the slt/datafusion/ or slt/duckdb/ directories

AdamGS added 2 commits March 6, 2026 14:11
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from myrrc March 6, 2026 14:14
@AdamGS AdamGS added the changelog/chore A trivial change label Mar 6, 2026
@AdamGS AdamGS changed the title Adamg/engine specific slt Engine specific SLT Mar 6, 2026
@AdamGS AdamGS enabled auto-merge (squash) March 6, 2026 14:16
@codspeed-hq
Copy link
codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 26.53%

⚡ 3 improved benchmarks
✅ 391 untouched benchmarks
⏩ 2052 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +26.53%
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +19.43%
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 903.3 µs +11.53%

Comparing adamg/engine-specific-slt (6198a15) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 2052 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (b1c5926) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@AdamGS AdamGS merged commit e719a17 into develop Mar 6, 2026
46 of 49 checks passed
@AdamGS AdamGS deleted the adamg/engine-specific-slt branch March 6, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0