8000 Log which FS is used in DuckDB as debug by AdamGS · Pull Request #6821 · vortex-data/vortex · GitHub
[go: up one dir, main page]

Skip to content

Log which FS is used in DuckDB as debug#6821

Merged
AdamGS merged 1 commit intodevelopfrom
adamg/debug-log-resolved-fs
Mar 6, 2026
Merged

Log which FS is used in DuckDB as debug#6821
AdamGS merged 1 commit intodevelopfrom
adamg/debug-log-resolved-fs

Conversation

@AdamGS
Copy link
Contributor
@AdamGS AdamGS commented Mar 6, 2026

This log is currently just noisy in benchmarks, I remember that's was the thing we agreed to do

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a10y and gatesn March 6, 2026 13:56
@AdamGS AdamGS added the changelog/chore A trivial change label Mar 6, 2026
@codspeed-hq
Copy link
codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 26.53%

⚡ 3 improved benchmarks
✅ 391 untouched benchmarks
⏩ 2052 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.5 ms +19.43%
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 903.3 µs +11.53%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +26.53%

Comparing adamg/debug-log-resolved-fs (f198dc3) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 2052 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (b1c5926) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@AdamGS AdamGS merged commit fd0f661 into develop Mar 6, 2026
47 of 51 checks passed
@AdamGS AdamGS deleted the adamg/debug-log-resolved-fs branch March 6, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0