Conversation
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
| let v: I = v.as_(); | ||
| sum = CheckedAdd::checked_add(&sum, &v)?; | ||
| } | ||
| let v: I = v.as_() * valid.as_(); |
Contributor
There was a problem hiding this comment.
Instead of * by 0 use bitwise and with a bool or T?
Contributor
Author
There was a problem hiding this comment.
it just seems like more work, because it needs to be with T::MAX or 0 instead of 0/1.
Contributor
Author
There was a problem hiding this comment.
not even MAX, just all 1
Contributor
There was a problem hiding this comment.
& is much cheeper than *. I think the compiler will work it our since there will be a zext u1 to uX, so it know the value is 0/1
Contributor
Author
There was a problem hiding this comment.
there's no BitAnd for uX
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
| } | ||
| let v: I = v.as_() * valid.as_(); | ||
|
|
||
| sum = CheckedAdd::checked_add(&sum, &v)?; |
Contributor
There was a problem hiding this comment.
There is still a branch here tho?
Contributor
Author
There was a problem hiding this comment.
one branch we can't avoid as long as we only have checked arithmetic
joseph-isaacs
approved these changes
Mar 5, 2026
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
4e511cd to
98fbd7a
Compare
Merging this PR will improve performance by 10.87%
Performance Changes
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just noticed this code path while refactoring something else, and figured this is better.
I think the trait bounds could be made nicer, but I'll leave that to a bigger refactor.