Remove sparse metadata prost wrapper#6761
Merged
connortsui20 merged 1 commit intodevelopfrom Mar 2, 2026
Merged
Conversation
gatesn
requested changes
Mar 2, 2026
8000
bee63af to
3db5107
Compare
Contributor
Author
|
Honestly I think a test that would have caught my mistake would be nice but I'm not really sure of a good way to write one. |
gatesn
reviewed
Mar 2, 2026
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
3db5107 to
08912dc
Compare
gatesn
approved these changes
Mar 2, 2026
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
## Summary Similar in nature to vortex-data#6751 and vortex-data#6759. We want to be able to work with in-memory metadata more easily, and we also want to make sure all scalar deserialization happens is `deserialize` instead of `build`. This is the last of the changes to metadata needed to unblock array-valued scalars in metadata. ## Testing Existing tests should be sufficient. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking Issue: #6771
Similar in nature to #6751 and #6759. We want to be able to work with in-memory metadata more easily, and we also want to make sure all scalar deserialization happens is
deserializeinstead ofbuild. This is the last of the changes to metadata needed to unblock array-valued scalars in metadata.Testing
Existing tests should be sufficient.