fix[util]: add balanced reduce iterator#6737
Merged
joseph-isaacs merged 6 commits intodevelopfrom Mar 2, 2026
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
AdamGS
reviewed
Mar 2, 2026
AdamGS
reviewed
Mar 2, 2026
AdamGS
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
This is cool, just some minor comments
AdamGS
reviewed
Mar 2, 2026
vortex-utils/src/iter.rs
Outdated
| /// |\ | ||
| /// a b | ||
| /// ``` | ||
| pub trait ReduceBalancedIterExt: Iterator + Sized { |
Contributor
There was a problem hiding this comment.
trait bounds for these are always weird IMO, I think what Itertools does is that the trait only requires Iterator and each function has specific additional bounds (Like Self: Sized)
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
We want expr/array tree to be wide not deep. We use a balanced reduce added in this PR and use in list_contains and or/and collect from exprs --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want expr/array tree to be wide not deep.
We use a balanced reduce added in this PR and use in list_contains and or/and collect from exprs