Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Co-authored-by: Andrew Duffy <a10y@users.noreply.github.com> Signed-off-by: Nicholas Gates <gatesn@users.noreply.github.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will improve performance by 12.36%
Performance Changes
Comparing 
Footnote 8000 s
|
joseph-isaacs
pushed a commit
that referenced
this pull request
Mar 4, 2026
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
Updates the VTable plan to remove the `FooInner<V>` struct. So now `Foo<V>` is not internally Arc'd. Downsides: * We lose the ability to go from `&Foo<V> -> FooRef` with only an Arc::clone. Turns out we were never doing this anyway, and where we _do_ need return self.clone() it happens to be on the type-erased API which remains internally arc'd. Upsides: * Borrowed downcasts `as_::<V>() -> &Foo<V>` can now return the full `Foo` wrapper struct, instead of just the associated type (`-> &V::Metadata`). This is a nicer API for users wanting to access typed fields instead of having to separately access shared properties from the erased object. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: Nicholas Gates <gatesn@users.noreply.github.com> Co-authored-by: Andrew Duffy <a10y@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the VTable plan to remove the
FooInner<V>struct. So nowFoo<V>is not internally Arc'd.Downsides:
&Foo<V> -> FooRefwith only an Arc::clone. Turns out we were never doing this anyway, and where we do need return self.clone() it happens to be on the type-erased API which remains internally arc'd.Upsides:
as_::<V>() -> &Foo<V>can now return the fullFoowrapper struct, instead of just the associated type (-> &V::Metadata). This is a nicer API for users wanting to access typed fields instead of having to separately access shared properties from the erased object.