Some adjustments to methods on ExtDTypeRef#6716
Merged
connortsui20 merged 1 commit intodevelopfrom Feb 28, 2026
Merged
Conversation
ExtDTypeRef
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
eb0afe5 to
8db2200
Compare
gatesn
approved these changes
Feb 28, 2026
| } | ||
| } | ||
|
|
||
| // struct PythonDisplay<'a>(&'a dyn DynExtDType); |
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
## Summary Makes some adjustments to code that slipped into the a previous PR. Mostly related to display logic. Ideally we would make it so that all of them don't have this `impl Display` logic but we can do that another time. ## API Changes Some of these methods shouldn't be public, and this reverts it. ## Testing N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes some adjustments to code that slipped into the a previous PR. Mostly related to display logic. Ideally we would make it so that all of them don't have this
impl Displaylogic but we can do that another time.API Changes
Some of these methods shouldn't be public, and this reverts it.
Testing
N/A