feat[array]: refactor invert compute kernel to lazy not#6446
Merged
joseph-isaacs merged 3 commits intodevelopfrom Feb 12, 2026
Merged
feat[array]: refactor invert compute kernel to lazy not#6446joseph-isaacs merged 3 commits intodevelopfrom
not#6446joseph-isaacs merged 3 commits intodevelopfrom
Conversation
…nArray Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
not via ScalarF…
8000
not
Merging this PR will improve performance by 11.31%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
commented
Feb 12, 2026
Contributor
Author
There was a problem hiding this comment.
scalar_fn pushdown handles these
…nArray Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
robert3005
approved these changes
Feb 12, 2026
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
fastio
pushed a commit
to fastio/vortex
that referenced
this pull request
Mar 10, 2026
…a#6446) ## Does this PR closes an open issue or discussion? <!-- This helps us keep track of fixed issues and changes. --> - Closes #. ## What changes are included in this PR? We want lazy compute. This PR moves invert compute to use the lazy compute model with array.not() building a scalar_fn with expr=not ## What is the rationale for this change? <!-- Why do you propose this change, and why did you choose this approach. This helps reviewers and other readers understand changes, creates a shared understanding of the issue and codebase, and improves their ability to work with this change and offer better suggestions. --> ## How is this change tested? <!-- Changes should be tested, we expect changes to fit in one of the following categories: 1. Verifying existing behavior is maintained. 2. For serialization related changes - Compatibility should be maintained or explicitly broken. 3. For new behavior and functionality, this helps us maintaining that desired behavior in the future. --> ## Are there any user-facing changes? ```rust #[deprecated(note = "use array.not() via ArrayBuiltins instead")] pub fn invert(array: &dyn Array) -> VortexResult<ArrayRef> { array.to_array().not() } ``` --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR closes an open issue or discussion?
What changes are included in this PR?
We want lazy compute. This PR moves invert compute to use the lazy compute model with array.not() building a scalar_fn with expr=not
What is the rationale for this change?
How is this change tested?
Are there any user-facing changes?