break[expr]: remove Expression.evaluate use Array.apply(expr) instead#6167
Merged
joseph-isaacs merged 2 commits intodevelopfrom Jan 27, 2026
Merged
break[expr]: remove Expression.evaluate use Array.apply(expr) instead#6167joseph-isaacs merged 2 commits intodevelopfrom
joseph-isaacs merged 2 commits intodevelopfrom
Conversation
fd953ab to
3f58d64
Compare
robert3005
approved these changes
Jan 27, 2026
Merging this PR will degrade performance by 32.04%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | u8_FoR[10M] |
8.5 µs | 6.2 µs | +36.77% |
| ⚡ | Simulation | bench_compare_varbin[(10000, 32)] |
190.5 µs | 170.7 µs | +11.6% |
| ⚡ | Simulation | bench_compare_varbin[(10000, 128)] |
203.9 µs | 183.6 µs | +11.02% |
| ⚡ | Simulation | bench_compare_varbin[(10000, 2)] |
186.2 µs | 166.3 µs | +11.97% |
| ⚡ | Simulation | bench_compare_varbin[(10000, 4)] |
186.8 µs | 166.8 µs | +12% |
| ⚡ | Simulation | bench_compare_varbin[(10000, 8)] |
187.1 µs | 167.2 µs | +11.88% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 2)] |
1,096.1 µs | 904.1 µs | +21.24% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 128)] |
1,113 µs | 920.9 µs | +20.85% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 32)] |
1,099.9 µs | 908.3 µs | +21.09% |
| ⚡ | Simulation | bench_compare_varbinview[(10000, 128)] |
203.4 µs | 183.5 µs | +10.89% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 2048)] |
1.4 ms | 1.2 ms | +15.64% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 512)] |
1.2 ms | 1 ms | +18.82% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 8)] |
1,096.4 µs | 904.9 µs | +21.17% |
| ⚡ | Simulation | bench_compare_varbin[(100000, 4)] |
1,096.5 µs | 904.4 µs | +21.24% |
| ⚡ | Simulation | bench_compare_varbinview[(10000, 4)] |
186.5 µs | 166.3 µs | +12.18% |
| ⚡ | Simulation | bench_compare_varbinview[(10000, 2)] |
186 µs | 166.3 µs | +11.84% |
| ⚡ | Simulation | bench_compare_varbinview[(100000, 2)] |
1,095.4 µs | 904.4 µs | +21.12% |
| ⚡ | Simulation | bench_compare_varbinview[(10000, 32)] |
190.7 µs | 170.2 µs | +12.03% |
| ⚡ | Simulation | bench_compare_varbinview[(10000, 8)] |
187.1 µs | 167.3 µs | +11.84% |
| ⚡ | Simulation | bench_compare_varbinview[(100000, 2048)] |
1.4 ms | 1.2 ms | +15.67% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Comparing ji/remove-expression-eval (c8f270a) with develop (39edf52)
Footnotes
-
1219 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
…#6167) Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was a foot gun.