10000 Bump version to 0.1.1, Update Changelog by chlafreniere · Pull Request #25 · vors/jupyter-powershell · GitHub
[go: up one dir, main page]
Skip to content

Bump version to 0.1.1, Update Changelog #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2019
Merged

Bump version to 0.1.1, Update Changelog #25

merged 5 commits into from
Oct 22, 2019

Conversation

chlafreniere
Copy link
Collaborator

Bump version to 0.1.1, Update Changelog with quick description of bug fix.

@vors
Copy link
Owner
vors commented Oct 22, 2019

This is a git nit: the commit history should not look like this (it includes old commits)
image

That's not a biggy since you can simply use the "Squash and merge" button to do the right thing, but I suggest to learn how to avoid such things in the future and have a nice intentional commits in PRs.

vors
vors approved these changes Oct 22, 2019
View reviewed changes
Copy link
Owner
@vors vors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not merging because you can do it yourself! :)

@chlafreniere
Copy link
Collaborator Author
chlafreniere commented Oct 22, 2019 •
edited
Loading

Thanks, @vors!

Looks like I can't merge myself actually:

image

@vors
Copy link
Owner
vors commented Oct 22, 2019

You need to accept the invitation to be the maintainer

image

Here is a link to accept: https://github.com/vors/jupyter-powershell/invitations

@chlafreniere chlafreniere merged commit b751b0d into vors:master Oct 22, 2019
@chlafreniere chlafreniere deleted the updateto011 branch October 22, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vors vors vors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlafreniere @vors
0