Attempt at better error reporting.

Signed-off-by: Ralph Gasser <rg@pontius.ch>
vitrivr · Aug 23, 2024 · 8aecbef · 8aecbef
1 parent 7f276a2
commit 8aecbef
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/...engine-module-m3d/src/main/kotlin/org/vitrivr/engine/model3d/renderer/ExternalRenderer.kt b/...engine-module-m3d/src/main/kotlin/org/vitrivr/engine/model3d/renderer/ExternalRenderer.kt
@@ -5,10 +5,7 @@ import org.vitrivr.engine.core.model.mesh.texturemodel.Model3d
 import org.vitrivr.engine.model3d.lwjglrender.render.RenderOptions
 import org.vitrivr.engine.model3d.lwjglrender.window.WindowOptions
 import java.awt.image.BufferedImage
-import java.io.Closeable
-import java.io.IOException
-import java.io.ObjectInputStream
-import java.io.ObjectOutputStream
+import java.io.*
 import kotlin.jvm.optionals.getOrNull
 
 /**
@@ -81,18 +78,23 @@ class ExternalRenderer : Closeable {
         /** The [ObjectInputStream] used by the [ExternalRenderer]. */
         val ois: ObjectInputStream
 
+        /** The standard error */
+        val err: BufferedReader
+
         init {
             val javaBin = ProcessHandle.current().info().command().getOrNull() ?: throw IllegalStateException("Could not determine JAVA_HOME.")
             val classpath = System.getProperty("java.class.path")
             val processBuilder = ProcessBuilder(javaBin, "-cp", classpath, "-XstartOnFirstThread", CLASS_NAME)
             this.process = processBuilder.start()
 
             /* Initialize streams. */
-            if (this.process.isAlive) {
+            this.err = this.process.errorReader()
+            try {
                 this.oos = ObjectOutputStream(this.process.outputStream)
                 this.ois = ObjectInputStream(this.process.inputStream)
-            } else {
-                throw IllegalStateException("Failed to start external renderer.")
+            } catch (e: Throwable) {
+                val err = this.err.readText()
+                throw IllegalStateException("Failed to start external renderer due to error: $err", e)
             }
         }
 
@@ -115,6 +117,9 @@ class ExternalRenderer : Closeable {
             } catch (e: IOException) {
                 this.ois.reset()
                 throw IllegalStateException("Could not parse model due to IO exception.", e)
+            } catch (e: IOException) {
+                this.ois.reset()
+                throw IllegalStateException("Could not parse model due to IO exception.", e)
             }
             return image
         }