feat(core): add collision detection and update methods #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Oct 6, 2025
packages/kit/src/utils/rpc.ts
Outdated
| handler = result.handler | ||
| } | ||
|
|
||
| return ((...args: ARGS) => { |
There was a problem hiding this comment.
We could do the handling on birpc side instead of wrapping the function.
packages/kit/src/utils/rpc.ts
Outdated
| const result = handler(...args) | ||
| if (result instanceof Promise) { | ||
| return result.catch((error) => { | ||
| debug(`RPC call "${definition.name}" failed:`, error) |
There was a problem hiding this comment.
Error should not go to debug (which is default to silent). We could have a logger interface where for now could be a simple abstraction of console.log and console.error
pyyupsk
commented
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Client-side broadcast for reactive updates not included