Switch to cibuildwheel github action and skip 3.10 wheel building #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like building fails on Windows and OSX because of numpy issues. Numpy wheels for 3.10 are not available so we might have to wait until at least then to build Python 3.10 wheels for vispy. @almarklein you ok with me skipping building 3.10 wheels for now? |
|
Numpy prerelease wheels are available from here: numpy/numpy#19630 (comment) But not sure we want to build wheels against pre-releases. |
Merged
Missing dependency wheels that are difficult to compile from source
|
TODO: Re-enable wheel building for Python 3.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the build issues identified and discussed in #2116
Currently cibuildwheel is trying to build with Python 3.10. However, many libraries don't have wheels for 3.10 yet (including vispy) and this causes issues for CI. We depend on Pillow for testing our wheels and since Pillow doesn't currently have a 3.10 wheel it tries to build from source during cibuildwheel's test phase. This fails with some missing C dependencies.
This PR switches to using the new PyPA-based cibuildwheel github action and skips testing the wheel for Python 3.10.