8000 Remove awa check triggering silent file edits. by jpmor · Pull Request #698 · vimwiki/vimwiki · GitHub
[go: up one dir, main page]
Skip to content

Remove awa check triggering silent file edits. #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Remove awa check triggering silent file edits. #698

merged 1 commit into from
Jun 5, 2019

Conversation

jpmor
Copy link
@jpmor jpmor commented May 4, 2019 •
edited
Loading

This is a change to 8000 vimwiki#base#edit_file. Currently if &autowriteall && !&hidden are set, commands are executed silently. The justification in comments for this is:
in this case, the file is saved before switching to the new buffer. This causes Vim to show two messages in the command line which triggers the annoying hit-enter prompt. Solution: show no messages at all.

Here's the original issue that lead to this being added: #445

I've opened a PR to remove this because (1.) The bug described in that issue and in the above comment is not occurring anymore and (2.) it's useful to see filename and cursor position displayed when switching links, and that is lost with silent execute.

@ranebrown
Copy link
Contributor

@jpmor my concern with this change is that the problem might still occur on older Vim versions. I think it is also dependent on your cmdheight setting and possibly other settings.

Have you tested different Vim versions and using a minimal .vimrc?

@jpmor
Copy link
Author
jpmor commented May 5, 2019 •
edited
Loading

Hey @ranebrown - I tried the following minimal .vimrc where ~/vimwiki has the conditional removed:

call plug#begin('~/.vim/plug')
  Plug '~/vimwiki'
call plug#end()

I gave this a try with 7.4, 8.0, 8.1 and was not able to reproduce the "hit-enter" bug.

@ranebrown
Copy link
Contributor

I also tested and didn't get the hit enter prompt. @jpmor can you update the changelog?

@jpmor
Copy link
Author
jpmor commented May 9, 2019

@ranebrown just updated changelog.

@ranebrown
Copy link
Contributor

@guakamole can you confirm removing this check doesn't cause problems since you opened the original issue? I want to make sure it isn't specific to certain settings since we have not been able to reproduce the behavior described in #445.

@ranebrown
Copy link
Contributor

@jpmor can you update the changelog and move this to the removed section? I was hoping to get some more feedback but doesn't look like that is going to happen.

@jpmor
Copy link
Author
jpmor commented Jun 5, 2019 •
edited
Loading

Hi @ranebrown - updated the changelog again and moved the comment to the removed section.

@ranebrown ranebrown merged commit b997e68 into vimwiki:dev Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmor @ranebrown
0