8000 Add basic GTD-style token highlighting by claman · Pull Request #1315 · vimwiki/vimwiki · GitHub
[go: up one dir, main page]
Skip to content

Add basic GTD-style token highlighting #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2023
Merged

Add basic GTD-style token highlighting #1315

merged 6 commits into from
Jun 22, 2023

Conversation

claman
Copy link
Contributor
@claman claman commented Mar 16, 2023 •
edited
Loading

Steps for submitting a pull request:

  • ALL pull requests shou 8000 ld be made against the dev branch!
  • Take a look at CONTRIBUTING.MD
  • Reference any related issues.
  • Provide a description of the proposed changes.
  • PRs must pass Vint tests and add new Vader tests as applicable.
  • Make sure to update the documentation in doc/vimwiki.txt if applicable,
    including the Changelog and Contributors sections.

Addresses #309 by adding highlighting for GTD-style @project, +context and due tokens

@tinmarino
Copy link
Member

Hello @claman,

It seems good to me. Can you please include a screenshot of the colors before and after?
Also it would be nice to have a regression test. Syntax stuff often step each other.

@tinmarino
Copy link
Member

Relates to issue #309

@claman
Copy link
Contributor Author
claman commented Mar 16, 2023

Hello @claman,

It seems good to me. Can you please include a screenshot of the colors before and after? Also it would be nice to have a regression test. Syntax stuff often step each other.

Thanks! I'll be able to work on this some more over the weekend. I do have to confess that I only have a super basic understanding of what regression testing is.

@tinmarino tinmarino merged commit 322d22b into vimwiki:dev Jun 22, 2023
tinmarino added a commit to tinmarino/vimwiki that referenced this pull request Jun 22, 2023
@tinmarino
CI: Add test for highlight dates (issue vimwiki#309, pr vimwiki#1315)
e0a04e1
This was referenced Jun 22, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claman @tinmarino
0