Support angle bracket escaped markdown urls #1211
Conversation
There was a problem hiding this comment.
Please copy-paste a snippet of what you see before and after the changes.
Also note the hardcoded regex because this may break some user configuration.
A link to that markdown spec in comment would be nice (easier to verify).
That said, the improvement seems nice, thank you for the effort. With small changes to get it safe, sure it will be accetpted.
let valid_chars_url = '[^[:cntrl:]]'
let mkd_syntax.rxWeblink1Prefix = vimwiki#u#escape(mkd_syntax.rxWeblink1Prefix)
let mkd_syntax.rxWeblink1Separator = vimwiki#u#escape(mkd_syntax.rxWeblink1Separator)
There was a problem hiding this comment.
This is hardcoded => bad
Please better change the default data in vars.vim
There was a problem hiding this comment.
Would something like let mkd_syntax.rxWeblink1Separator = vimwiki#u#escape(mkd_syntax.rxWeblink1Separator).'<\=' be preferable or should I pull this into a new variable entirely? I'm not sure how to escape it without ruining the \=
| let valid_chars_url = '[^[:cntrl:]]' | ||
|
|
||
| let mkd_syntax.rxWeblink1Prefix = vimwiki#u#escape(mkd_syntax.rxWeblink1Prefix) | ||
| let mkd_syntax.rxWeblink1Separator = vimwiki#u#escape(mkd_syntax.rxWeblink1Separator) |
There was a problem hiding this comment.
This is hardcoded => bad
Please better change the default data in vars.vim
There was a problem hiding this comment.
Would something like let mkd_syntax.rxWeblink1Separator = vimwiki#u#escape(mkd_syntax.rxWeblink1Separator).'<\=' be preferable or should I pull this into a new variable entirely? I'm not sure how to escape it without ruining the \=
|
Visually there will be no change, markdown-style links will be concealed the same way. I should have mentioned that this allows
Pandoc doesn't mention it in the docs but it's in the code if that helps. Thanks! I will fix up the regex shortly. |
|
@CharlesSchimmel @tinmarino this is exactly what I want. Anything I can help with? I'd like to get this PR merged. |
|
I was coming to check if just this feat had been discussed before to work on it and make a PR. I'm glad to see that someone has already worked on it. I would like to see this PR merge! |
|
Rebased with squashed <= It works fine actually I am really sorry for the delay, got confused => Was waiting for @CharlesSchimmel who was actually waiting for my answer. Sorry guys. And well thank you very much @CharlesSchimmel for the PR (and the patience). I hope to see you in another PR 😃 |
Very small change to support Markdown links with angle bracket escaped URIs, like
[link title](<path/to/some file>)to enable link-following of angle bracket escaped markdown links. This syntax is part of the the Commonmark spec:This is also helpful is people use Obsidian alongside their Vimwiki as Obsidian strongly conforms to markdown standards and will not parse links with enescaped spaces. I believe this is all needed to support link following and concealment/preview.
devbranch!doc/vimwiki.txtif applicable,including the Changelog and Contributors sections.
Edited to specifically highlight link-following of angle bracket escaped markdown links and add related commonmark spec