Add "string" to cppRawDelimiter group name #32
Conversation
This change fixes handling of raw strings in matchparen - a standard plugin that highlights matching parentheses. The bug that I'm fixing manifests in the following code: foo(bar( R"( )" ) ); If you move over parens in this code in Vim, you'll see that wrong ones are highlighted. This is because matchparen uses syntax highlighting to find (and skip) string literals. To be precise, it assumes that all string literals are highlighted with a syntax group whose name contains "string". Because we used "cppRawDelimiter", which does not contain "string" in it, parens in raw string delimiters confused the matchparen algorithm.
|
Sorry, I don't still understand what you fix. https://github.com/rburny/vim-cpp/commit/0911af4c4c2ba8b54fe1a90a36dd0a3f1341da83?diff=split AFAICS, you change only spelling of |
|
Yes, that's right - I'm only changing the name. However, matchparen parses this name, so changing it can change its rehavior! It is very tricky, though - so let me explain. First of all, matchparen is the standard plugin that highlights matching braces. E.g. if you write How does matchparen algorithm know it should highlight the closing paren, not the one inside string? It does not have any language-specific rules - instead, it relies on syntax highlighting. The exact rule, described in So this heuristics only works if each syntax highlighting group is named properly. Unfortunately, "cppRawDelimiter" doesn't have the required "string" in its name, causing bad interactions with matchparen. The new name contains "string", and matchparen works well. |
|
Ah, you are right. I didn't know it. |
Add "string" to cppRawDelimiter group name
|
Thank you |
|
Thank you! This has been bugging me for a long time! |
This change fixes handling of raw strings by matchparen - a standard plugin that highlights matching parentheses. The bug that I'm fixing manifests in the following code:
If you move over parens in this code in Vim, you'll see that wrong ones are highlighted. This is because matchparen uses syntax highlighting to find (and skip) string literals. To be precise, it assumes that all string literals are highlighted with a syntax group whose nam 7440 e contains "string". Because we used "cppRawDelimiter", which does not contain "string", parens in raw string delimiters were not handled properly.