10000 Added C++14 binary literal highlight by rhysd · Pull Request #31 · vim-jp/vim-cpp · GitHub
[go: up one dir, main page]
Skip to content

Added C++14 binary literal highlight #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2015
Merged

Added C++14 binary literal highlight #31

merged 1 commit into from
Sep 23, 2015

Conversation

rhysd
Copy link
Contributor
@rhysd rhysd commented Feb 28, 2015

ISO/IEC 14882:2014 was issued at the beginning of this year. So we should start to improve vim-cpp to work well with C++14 code, I think.

As a first work, I added g:cpp_no_cpp14 variable check and a highlight for binary literal.

int main()
{
    0b01010100010;
    0b01010100010ll;
    0b01010100010ul;

    return 0;
}

This was referenced Feb 28, 2015
Closed
Open
@mattn
Copy link
Member
mattn commented Feb 28, 2015

LGTM but leave to others.

@rhysd
Copy link
Contributor Author
rhysd commented Feb 28, 2015

@mattn

Thank you for your review.

Can anyone else review this PR?

@mattn
Copy link
Member
mattn commented Mar 2, 2015 
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね？

@rhysd
Copy link
Contributor Author
rhysd commented Mar 2, 2015 
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね？

必要でした．ありがとうございます．今夜修正します．

< 8000 /div>
@rhysd
Copy link
Contributor Author
rhysd commented Mar 2, 2015

@mattn

修正しました！

@rburny
Copy link
Contributor
rburny commented Sep 22, 2015

Hello,
could you please merge this pull request? Or alternatively, would it make sense to expand cppNumber definition to also cover digit separators?

@rhysd
Copy link
Contributor Author
rhysd commented Sep 23, 2015

@rburny

Hi, could you review this PR?
This PR is not merged yet because of lack of reviewer.

mattn added a commit that referenced this pull request Sep 23, 2015
@mattn
Merge pull request #31 from rhysd/cpp14
5132f6d 
Added C++14 binary literal highlight
@mattn mattn merged commit 5132f6d into vim-jp:master Sep 23, 2015
@mattn
Copy link
Member
mattn commented Sep 23, 2015

@rhysd 👍

@mattn
Copy link
Member
mattn commented Sep 23, 2015

I'll send latest syntax/cpp.vim to vim-dev

@rburny
Copy link
Contributor
rburny commented Sep 23, 2015

Thanks!
This one's already handled, but if you need review in future, feel free to ping me.

@rhysd
Copy link
Contributor Author
rhysd commented Sep 24, 2015

@mattn

I'll send latest syntax/cpp.vim to vim-dev

🐶👍

@rburny

This one's already handled, but if you need review in future, feel free to ping me.

Thank you for your help!
When I implement additional support, I may ping you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhysd @mattn @rburny
0