Adding Recognizer interface to LuisRecognizer (microsoft#326)

axelsrz · web-flow · commit 65f73d0d52b5 · 2019-09-30T18:14:27.000-07:00
* Adding Recognizer interface to LuisRecognizer

* adding abstract method
diff --git a/libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer.py b/libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer.py
@@ -8,15 +8,21 @@
 from azure.cognitiveservices.language.luis.runtime.models import LuisResult
 from msrest.authentication import CognitiveServicesCredentials
 
-from botbuilder.core import BotAssert, IntentScore, RecognizerResult, TurnContext
+from botbuilder.core import (
+    BotAssert,
+    IntentScore,
+    Recognizer,
+    RecognizerResult,
+    TurnContext,
+)
 from botbuilder.schema import ActivityTypes
 
 from . import LuisApplication, LuisPredictionOptions, LuisTelemetryConstants
 from .activity_util import ActivityUtil
 from .luis_util import LuisUtil
 
 
-class LuisRecognizer:
+class LuisRecognizer(Recognizer):
     """
     A LUIS based implementation of <see cref="IRecognizer"/>.
     """
@@ -95,7 +101,7 @@ def top_intent(
 
         return top_intent or default_intent
 
-    async def recognize(
+    async def recognize(  # pylint: disable=arguments-differ
         self,
         turn_context: TurnContext,
         telemetry_properties: Dict[str, str] = None,
diff --git a/libraries/botbuilder-core/botbuilder/core/recognizer.py b/libraries/botbuilder-core/botbuilder/core/recognizer.py
@@ -1,12 +1,12 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 
-from abc import ABC
+from abc import ABC, abstractmethod
 from .turn_context import TurnContext
 from .recognizer_result import RecognizerResult
 
 
 class Recognizer(ABC):
-    @staticmethod
-    async def recognize(turn_context: TurnContext) -> RecognizerResult:
+    @abstractmethod
+    async def recognize(self, turn_context: TurnContext) -> RecognizerResult:
         raise NotImplementedError()
