8000 feat: add player by ankit-v2-3 · Pull Request #2 · video-db/videodb-python · GitHub
[go: up one dir, main page]
Skip to content

feat: add player #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2023
Merged

feat: add player #2

merged 5 commits into from
Dec 28, 2023

Conversation

ankit-v2-3
Copy link
Collaborator
@ankit-v2-3 ankit-v2-3 commented Dec 28, 2023 •
edited by ashish-spext
Loading

Pull Request

Description:
Add play() method to Video, SearchResult, Shot object. and play_stream() utility function

Refactor:
Video class
self.stream_link -> self.stream_url
self.player_url (new self variable for player link)
self.thumbnail -> self.thumbnail_url
video.get_stream() -> video.generate_stream()
video.get_thumbnail() -> video.generate_thumbnail()
video.play() (new method open the player url in the default browser/notebook and return player url.)

SearchResult class
self.stream_link -> self.stream_url
self.player_url (new self variable for player link)
result.play() (new method open the player url in the default browser/notebook and return player url.)

Shot class
self.stream -> self.stream_url
self.player_url (new self variable for player link)
short.get_stream() -> shot.generate_stream( )
shot.play() (new method open the player url in the default browser/notebook and return player url.)

Changes:

  • Add player

Checklist:

  • Code follows project coding standards
  • Tests have been added or updated
  • Code Review
  • Manual test after merge
  • All checks passed

@ashish-spext ashish-spext merged commit 0fb1f53 into main Dec 28, 2023
@ankit-v2-3 ankit-v2-3 deleted the ar/add-player branch December 28, 2023 15:17
ankit-v2-3 pushed a commit that referenced this pull request Mar 13, 2025
@0xrohitgarg
Merge pull request #2 from video-db/main
125f8ec 
Sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-spext ashish-spext Awaiting requested review from ashish-spext

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankit-v2-3 @ashish-spext
0