8000 Add quotes from The Office by Stelage · Pull Request #5 · victrme/i18n-quotes · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes from The Office #5

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

Stelage
Copy link
Contributor
@Stelage Stelage commented Feb 2, 2025

Hello,

I'm currently working on Bonjourr#542

As the first step, I added some quotes to this project.

@victrme
Copy link
Owner
victrme commented Feb 2, 2025

Nice, thanks @Stelage !

I haven't tested it yet, but it looks good to me 👍

@Stelage Stelage marked this pull request as draft February 2, 2025 22:18
@Stelage Stelage marked this pull request as ready for review February 2, 2025 23:27
@Stelage
Copy link
Contributor Author
Stelage commented Feb 2, 2025

@victrme,

Update is done on both side as requested.
I also made a little improvement on error handling if somehow the requested file did not exists.
My initial suggestion was incorrect, as it prevented the error message from appearing.

Now, all potential errors are properly handled, ensuring clearer feedback.
image

The behavior was as follows before:
image

Repository owner deleted a comment from netlify bot Feb 3, 2025
@victrme
Copy link
Owner
victrme commented Feb 3, 2025

Thank you for the improved error handling 👍

@victrme victrme merged commit 5c452c9 into victrme:main Feb 3, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0