8000 Fix wrong optimization result of shifted out variable by yTakatsukasa · Pull Request #6019 · verilator/verilator · GitHub
[go: up one dir, main page]
Skip to content

Fix wrong optimization result of shifted out variable #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

Fix wrong optimization result of shifted out variable #6019

merged 3 commits into from
May 18, 2025

Conversation

yTakatsukasa
Copy link
Member

Fixes #6016

When a VarRef is shifted out, its polarity should be cleared too.

@yTakatsukasa yTakatsukasa changed the title Fix wrong optimization Fix wrong optimization result of shifted out variable May 18, 2025
@wsnyder
Copy link
Member
wsnyder commented May 18, 2025

Thanks, code seems good. I note this is still marked draft, I won't merge until see it's marked ready.

@yTakatsukasa yTakatsukasa marked this pull request as ready for review May 18, 2025 11:01
@yTakatsukasa
Copy link
Member Author

Now it's ready.

Thnaks @sdjasj for the interesting case.
I always appreciate your initial analysis quick dispatch @wsnyder .

@wsnyder wsnyder merged commit b26658f into verilator:master May 18, 2025
36 checks passed
@yTakatsukasa yTakatsukasa deleted the fix6016 branch May 18, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect simulation result due to some optimizations
2 participants
@yTakatsukasa @wsnyder
0