Hierarchical scheduling visualization in V3ExecGraph #6009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartłomiej Chmiel <bchmiel@antmicro.com>
45e9c53 to
af6a8f4
Compare
wsnyder
reviewed
May 16, 2025
There was a problem hiding this comment.
Thanks, definite massive improvement in readability.
In some of the designs I see there are some very massive mtask lengths intermixed with short ones. I do think it looses some critical information to make them all uniform. Maybe we could "snap" them to a grid of some uniform reasonable size. (That is a long one might snap to exactly length of 4 short ones)?
8000
Signed-off-by: Bartłomiej Chmiel <bchmiel@antmicro.com>
Signed-off-by: Bartłomiej Chmiel <bchmiel@antmicro.com>
|
I'd added mtask length normalization. For readability and to avoid overcomplicating implementation, tasks are shown in a single-task columns. |
|
Looks excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves V3ExecGraph
schedulegraph dumping.Old hierarchical version:
New hierarchical version:
Hierarchical schedules are separated with black
forks, thread allocations from multi-thread hierarchical tasks are shown as green tasks without dependencies.I'd normalized lengths of tasks for readability. This however may cause task length misinterpretation, for instance
mt23takes longer thanmt26/mt27but it is shown on the left to indicate when it started. @wsnyder I can restrict this kind of graph only for hierarchical verilation if you want.Dependencies were also simplified, so that they are shown from simulation execution perspective rather than scheduling. This means that tasks with dependencies on the same thread were simplified to only depend on their neighbour and there are no inter-schedule dependencies.
Normal multi-threaded verilation schedules are still a nightmare to watch but I don't think we would like to make those diagrams interactive for dependency tracking, especially considering that
packgraph shows them all in a more digestible manner.Old version:
New version:
