8000 Fix --x-initial and --x-assign random stability (#2662) by toddstrader · Pull Request #5958 · verilator/verilator · GitHub
[go: up one dir, main page]
Skip to content

Fix --x-initial and --x-assign random stability (#2662) #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 16, 2025
+674 −45
Merged

Fix --x-initial and --x-assign random stability (#2662) #5958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
095eefc
x rand test
toddstrader Apr 28, 2025
c2549d1
POC: VL_RAND_RESET PRNG stability
toddstrader Apr 25, 2025
f0005ca
runtime scope hashing -- WIP
toddstrader Apr 30, 2025
63e2e68
split rand reset into scoped and not
toddstrader May 1, 2025
8f740ca
format
toddstrader May 2, 2025
228a7c2
Handle classes
toddstrader May 2, 2025
76806e4
vltmt
toddstrader May 5, 2025
30434fb
VL_MT_SAFE
toddstrader May 5, 2025
fba7ab5
cleanup
toddstrader May 5, 2025
d53da10
remove xtemp initial assign
toddstrader May 5, 2025
31a388a
AstRand::m_reset rip out
toddstrader May 5, 2025
52ba867
fix rand initial
toddstrader May 5, 2025
5ad37ec
use --x-assign for XTEMP reset
toddstrader May 5, 2025
02925b3
this / vlSelf
toddstrader May 5, 2025
c2a5052
fix t_debug_emitv
toddstrader May 5, 2025
df85809
py fix
toddstrader May 5, 2025
cfb74a4
CR
toddstrader May 6, 2025
8d691d5
golden
toddstrader May 6, 2025
4680ade
unsafe
toddstrader May 6, 2025
2189af1
fallthrough
toddstrader May 6, 2025
8efb24b
CR
toddstrader May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fallthrough
  • Loading branch information
@toddstrader
toddstrader committed May 16, 2025
commit 2189af1ed6dcbbd396c84c42c7fde84eb1bd53e2
14 changes: 7 additions & 7 deletions include/verilated.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1759,13 +1759,13 @@ uint64_t VL_HASH(const char* key) VL_PURE {
const unsigned char* data2 = (const unsigned char*)data;

switch (len & 7) {
case 7: h ^= uint64_t(data2[6]) << 48;
case 6: h ^= uint64_t(data2[5]) << 40;
case 5: h ^= uint64_t(data2[4]) << 32;
case 4: h ^= uint64_t(data2[3]) << 24;
case 3: h ^= uint64_t(data2[2]) << 16;
case 2: h ^= uint64_t(data2[1]) << 8;
case 1: h ^= uint64_t(data2[0]); h *= m;
case 7: h ^= uint64_t(data2[6]) << 48; /* fallthrough */
case 6: h ^= uint64_t(data2[5]) << 40; /* fallthrough */
case 5: h ^= uint64_t(data2[4]) << 32; /* fallthrough */
case 4: h ^= uint64_t(data2[3]) << 24; /* fallthrough */
case 3: h ^= uint64_t(data2[2]) << 16; /* fallthrough */
case 2: h ^= uint64_t(data2[1]) << 8; /* fallthrough */
case 1: h ^= uint64_t(data2[0]); h *= m; /* fallthrough */
};

h ^= h >> r;
Expand Down
14 changes: 7 additions & 7 deletions src/V3String.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,13 @@ uint64_t VString::hash(const string& str) VL_PURE {
const unsigned char* data2 = (const unsigned char*)data;

switch (len & 7) {
case 7: h ^= uint64_t(data2[6]) << 48;
case 6: h ^= uint64_t(data2[5]) << 40;
case 5: h ^= uint64_t(data2[4]) << 32;
case 4: h ^= uint64_t(data2[3]) << 24;
case 3: h ^= uint64_t(data2[2]) << 16;
case 2: h ^= uint64_t(data2[1]) << 8;
case 1: h ^= uint64_t(data2[0]); h *= m;
case 7: h ^= uint64_t(data2[6]) << 48; /* fallthrough */
case 6: h ^= uint64_t(data2[5]) << 40; /* fallthrough */
case 5: h ^= uint64_t(data2[4]) << 32; /* fallthrough */
case 4: h ^= uint64_t(data2[3]) << 24; /* fallthrough */
case 3: h ^= uint64_t(data2[2]) << 16; /* fallthrough */
case 2: h ^= uint64_t(data2[1]) << 8; /* fallthrough */
case 1: h ^= uint64_t(data2[0]); h *= m; /* fallthrough */
};

h ^= h >> r;
Expand Down
0