Fix linking parameterized hierarchical blocks and recursive hierarchical blocks #4654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsnyder
reviewed
Nov 1, 2023
The problem (for recursive blocks) was that it sometime failed to find the library wrapper, with the mangled name, but recursive cells was linked to the Vrcm module so it creates a wrong name containing "__Vrcm", later m_hierBlocks.isHierBlock will fail to find the wrapper. An assertion is now added (here). It assures that the library wrappers must be linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterized hierarchical blocks without parameter overrides didn't link to the correct module (the library wrapper) during parameterization, instead it's the original module. It's because
m_hierBlocks.findByParamsis not used to find the modules if any_overrides is false.Recursive hierarchical blocks also failed to link to the correct modules because it search the modules with the mangled name. Now it uses its original name, to make it work properly.