8000 Improve parameterization algorithm for SV modules/classes (#4497) by donlon · Pull Request #4629 · verilator/verilator · GitHub
[go: up one dir, main page]
Skip to content

Improve parameterization algorithm for SV modules/classes (#4497) #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Improve parameterization algorithm for SV modules/classes (#4497) #4629

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
53e79ef
clean cellInterfaceCleanup in V3Param
donlon Oct 8, 2023
795ec6c
fix error on interface sel
donlon Oct 8, 2023
1cec1c2
simple rewrites
donlon Oct 8, 2023
8000
d80b7b8
do not use AstClass::isParameterized which is inaccurate and redundant
donlon Oct 8, 2023
0f5020c
remove `this->`
donlon Oct 8, 2023
0a65275
always copy original AstClass nodes for parameterization
donlon Oct 14, 2023
0f015f7
stash the deparam algorithm changes
donlon Oct 20, 2023
3f6e8b7
squash recent changes
donlon Oct 26, 2023
69c826a
revert something
donlon Oct 26, 2023
da9bcd0
fix lint-only mode with top-level interfaces (temporary fix)
donlon Oct 26, 2023
91a2616
Apply 'make format'
Oct 26, 2023
164445d
fix compiler error
donlon Oct 26, 2023
99550aa
update
donlon Oct 27, 2023
27068d2
update tests for hierarchical blocks
donlon Oct 31, 2023
da20584
fix using VLT files for recursive modules
donlon Oct 31, 2023
033f983
update
donlon Nov 1, 2023
b7eab0e
temporarily fix for recursive hier blocks
donlon Nov 1, 2023
983fd32
merge map for full param sets and overridden param sets
donlon Nov 1, 2023
ee6a3b2
use hash-based module name for hierarchical blocks
donlon Nov 1, 2023
fa670fb
Merge remote-tracking branch 'upstream/master' into pr/new-deparam-al…
donlon Nov 5, 2023
439f6e1
some fixes
donlon Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix compiler error
  • Loading branch information
@donlon
donlon committed Oct 26, 2023
commit 164445d13b87de1741f7e9cbe12bf93f36e46d4c
1 change: 1 addition & 0 deletions src/V3Param.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,7 @@ class ParamProcessor final {
}
}
}
(void)hasEmptyParam;
collectedParams->rehash();
foundp = modInfop->findNodeWithOverriddenParamSet(collectedParams.get());
if (!foundp) foundp = modInfop->findNodeWithFullParamS 4039 et(collectedParams.get());
Expand Down
0