Don't link AstRefDType if it has parameterized class ref (#4164) #4170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryszard Rozak <rrozak@antmicro.com>
|
Thanks, feel free to squash merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It (partially) fixes references to typedefs declared in parameterized classes. It also fixes #4164.
The problem still occurs if we have a reference to a typedef declared in a parameterized class, but we don't provide parameters in this reference.
I removed this line from a test
uvm_resource_types#(1,2,3)::rsrc_q_t rtab_paramed [string];, because it was incorrect. That class is not a parameterized class.