8000 Add license MIT · Pull Request #93 · vercel/next.js · GitHub
[go: up one dir, main page]

Skip to content

Add license MIT #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from Oct 29, 2016
Merged

Add license MIT #93

merged 6 commits into from Oct 29, 2016

Conversation

ghost
Copy link
@ghost ghost commented Oct 26, 2016

No description provided.

@@ -0,0 +1,21 @@
The MIT License (MIT)

Copyright (c) 2016 netx.js developers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the word next

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @jamo , i fix that.


## License

MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Hyper, Zeit wanted to omit the this License section from README and set the license in the repo settings so it shows like this:
image

Someone with the needed rights needs to add that, so we can omit it from README.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE file is explicit and git hosting agnostic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamstarkov yeah, I agree the LICENSE file should be in the repo, but I think we don't need it added to the README.

BTW, the license is also declared in package.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

though, it might seems a bit redundant, but its kind of standard of to declare license type in the pkg and in the end of README file, and specify full license text in LICENSE.
Im not suggesting to add License section to README, rather pointing out how convenient it is

@@ -0,0 +1,21 @@
The MIT License (MIT)

Copyright (c) 2016 next.js developers
Copy link
Contributor
@nkzawa nkzawa Oct 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copyright should include Zeit, Inc..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change copyright to Zeit, Inc.

@@ -378,3 +378,4 @@ The following issues are currently being explored and input from the community i
- Tony Kovanen ([@tonykovanen](https://twitter.com/tonykovanen)) – ▲ZEIT
- Guillermo Rauch ([@rauchg](https://twitter.com/rauchg)) – ▲ZEIT
- Dan Zajdband ([@impronunciable](https://twitter.com/impronunciable)) – Knight-Mozilla / Coral Project

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this \n?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default README.md has \n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove it since it's not related to license ?
And please squash all commits to one.

@rauchg rauchg merged commit a636ba3 into vercel:master Oct 29, 2016
@rauchg
Copy link
Member
rauchg commented Oct 29, 2016

Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0