8000 Change file name lib on example keep the same format by titeller · Pull Request #3227 · vercel/next.js · GitHub
[go: up one dir, main page]
Skip to content

Change file name lib on example keep the same format #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2017
Merged

Change file name lib on example keep the same format #3227

merged 1 commit into from
Nov 2, 2017

Conversation

titeller
Copy link
Contributor
@titeller titeller commented Nov 2, 2017 •
edited
Loading

I try to play examples on with-apollo, with-apollo-and-redux and with-apollo-auth and then i seen files name in lib folder is different format.

I think that should be the same format.

@titeller
Update react and react-don version 15.5.4 to 16.0.0
ea22bc2 
Change file name format on folder lib like /examples/with-apollo and /examples/with-apollo-and-redux
adamsoffer
adamsoffer approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor
@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks!

timneutkens
timneutkens requested changes Nov 2, 2017
View reviewed changes
Copy link
Member
@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@timneutkens timneutkens merge 8000 d commit 28767c0 into vercel:master Nov 2, 2017
timneutkens pushed a commit to timneutkens/next.js that referenced this pull request Nov 5, 2017
@titeller @timneutkens
Change file name lib on example keep the same format (vercel#3227)
d63460b 
Change file name format on folder lib like /examples/with-apollo and /examples/with-apollo-and-redux
@lock
Copy link
lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsoffer adamsoffer adamsoffer approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titeller @adamsoffer @timneutkens
2A48
0