8000 Strip ansi codes when logging client side by timneutkens · Pull Request #3138 · vercel/next.js · GitHub
[go: up one dir, main page]
Skip to content

Strip ansi codes when logging client side #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2017
Merged

Strip ansi codes when logging client side #3138

merged 1 commit into from
Oct 21, 2017

Conversation

timneutkens
Copy link
Member
@timneutkens timneutkens commented Oct 21, 2017 •
edited
Loading

They make client side errors in development mode unreadable.

Old:

screen shot 2017-10-21 at 11 39 00

New:

screen shot 2017-10-21 at 11 36 19

@timneutkens timneutkens requested a review from arunoda October 21, 2017 09:40
albinekb
albinekb approved these changes Oct 21, 2017
View reviewed changes
Copy link
Contributor
@albinekb albinekb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't like the mutating code, but as discussed in slack this is the best way currently, to make sure the strip-ansi package is not bundled in production

Nice fix though!! I always thought this was an error on my side 😄 (fish, iterm etc)

@timneutkens timneutkens merged commit a28bbb0 into vercel:master Oct 21, 2017
@timneutkens timneutkens deleted the fix/ansi-logs branch October 21, 2017 10:59
@lock
Copy link
lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@albinekb albinekb albinekb approved these changes

@arunoda arunoda Awaiting requested review from arunoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @albinekb
0