Add support for 64bit updaters on windows #704
+264
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #704 +/- ##
===========================================
- Coverage 40.46% 40.07% -0.39%
===========================================
Files 248 69 -179
Lines 19164 7715 -11449
Branches 2047 0 -2047
===========================================
- Hits 7755 3092 -4663
+ Misses 11048 4623 -6425
+ Partials 361 0 -361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
75400f0 to
923dce7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for 64-bit (and ARM64) updater binaries on Windows, expanding beyond the previous x86-only support. The changes enable architecture-specific update binaries to be packaged correctly based on the target runtime.
- Adds architecture-specific binary handling for Windows update executables (x86, x64, arm64)
- Updates build pipeline to generate separate artifacts for each Windows architecture
- Adds comprehensive test coverage to verify correct architecture binaries are included in packages
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/Velopack.Packaging.Tests/WindowsPackTests.cs |
Adds new test to verify correct architecture-specific update binaries are packaged |
src/vpk/Velopack.Packaging/HelperFile.cs |
Updates binary selection logic to choose architecture-specific Windows update binaries |
src/Directory.Build.targets |
Updates packaging to include multiple Windows architecture binaries instead of generic ones |
CLAUDE.md |
Adds comprehensive technical documentation about Velopack architecture and development processes |
.github/workflows/build-tests.yml |
Updates artifact dependencies to include new Windows architecture-specific artifacts |
.github/workflows/build-rust.yml |
Restructures build pipeline to generate separate Windows binary artifacts per architecture |
Keboo
previously approved these changes
Aug 8, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
10f9f49 to
c3e82d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.