Adding true MSI support #606
Conversation
Fixing output logging
Updating to use it to manually pack
Adding temp directory for when packages directory cannot be created.
And removing shortcuts
Adding check for writable directory
Adding launch after install
Fixing file loading parameters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #606 +/- ##
===========================================
- Coverage 40.87% 40.82% -0.06%
===========================================
Files 244 267 +23
Lines 18355 19457 +1102
Branches 2045 2128 +83
===========================================
+ Hits 7503 7943 +440
- Misses 10497 11125 +628
- Partials 355 389 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The test DownloadsLatestFullVersion needs to extract the root directory to ensure that it is properly cleaned up after the test runs, so that the test can run multiple times without error.
Fixed pathing issues on Windows pack tests Adding pipeline logging for missing wix dll
This is needed for MSI tests that rely on the velopack_wix.dll
Removes the binary listing step from the build workflow, as it is not needed and clutters the output.
Adds IProcessImpl.Exit for controlled process termination, replaces Environment.Exit with IProcessImpl.Exit calls, and adds a test implementation for IProcessImpl.
|
@Keboo, is this code going to be merged at some point? We're looking for an MSI installer for a project, and would love to use VeloPack. The app consists of a WPF client, a console client, and a Windows service. Because of the Windows service, I don't think we can currently use VeloPack. Thanks! |
|
@jaspet Yes this is what we are working on trying to get merged. However, this is only going to add support for generating an MSI and support for installing an application for all users vs per user. It does not add support for system services. This is on our roadmap but no ETA to report for that feature right now. |
Adds an explicit wxPython installation step for the `PythonWXPython` sample when building on macOS runners. This ensures the `libpng` dependency is met, preventing potential CI build failures caused by the missing library.
|
Are there any Updates on when this will get merged? |
This is a major update to the msi files that Velopack can create for Windows.
This is a breaking change for the vpk CLI. The only MSI deployment tool is replaced with this new
--msioption.There is a sample branch under
kdb/msi-exampleshowing the usage with the Avalonia sample application. The updates are under the dev-scripts.Unlike the previous MSI deployment tool that was modeled after the Clowd.Squirrel (and parent Squirrel project) that just injects a registry key to run on the startup of each user and perform a per-user install, this MSI is a true installer that can be used as a replacement for the Setup.exe.
The MSI currently has the following behavior:
--msiVersionOverride <Version>option to allow setting the MSI version as it is more restrictive than the normal version number.--instLocation perUseror--instLocation perMachinewhen running vpk pack to specify the location ahead of time. In these cases, the installation location dialog will not be shown to the user.--instLicense <License Markdown File>.--instWelcome <Welcome Markdown File>,--instReadMe <Readme Markdown File>, and--instConclusion <Conclusion Markdown File>. Be aware that though these are markdown files, the MSI really only supports plain text in these fields so nearly all formatting is stripped out.--msiBanner <Banner Bitmap>and--msiLogo <Background Bitmap>respectively. More discussion is needed on appropriate defaults for these.Fixes #389