8000 mypy annotations (basic) + libvcs update by tony · Pull Request #373 · vcs-python/vcspull · GitHub
[go: up one dir, main page]
Skip to content

mypy annotations (basic) + libvcs update #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 25, 2022
Merged

mypy annotations (basic) + libvcs update #373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5cc81e
build(deps): Add types-colorama, types-requests, types-PyYaml
tony Jun 11, 2022
41a2654
build(deps): libvcs 0.14.0a0 -> 0.17.0a0
tony Jul 31, 2022
797ac54
ci(mypy) Add mypy config
tony May 31, 2022
86af184
docs(developing): Update for flake8 and mypy
tony May 31, 2022
b38fe43
Start stubbing out mypy
tony May 31, 2022
146e222
ci(tests): Check mypy
tony May 31, 2022
71912e2
refactor: Basic mypy, refactor for new libvcs
tony Jun 12, 2022
873dad1
build(Makefile): Add monkeytype_{create,apply}
tony Sep 25, 2022
6dc6ad3
test(test_repo): Move to pathlib
tony Sep 25, 2022
4d0e874
docs(CHANGES): Note mypy annotations and libvcs update
tony Sep 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Start stubbing out mypy
  • Loading branch information
@tony
tony committed Sep 25, 2022
commit b38fe43b0e2b32d5711888925f63dcc578d7c5cf
4 changes: 3 additions & 1 deletion src/vcspull/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ def find_home_config_files(
def find_config_files(
path: Optional[Union[list[pathlib.Path], pathlib.Path]] = None,
match: Union[list[str], str] = ["*"],
filetype: list[Literal["json", "yaml"]] = ["json", "yaml"],
filetype: Union[
Literal["json", "yaml", "*"], list[Literal["json", "yaml", "*"]]
] = ["json", "yaml"],
include_home: bool = False,
):
"""Return repos from a directory and match. Not recursive.
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def test_in_dir(
def test_find_config_path_string(
config_path: pathlib.Path, yaml_config: pathlib.Path, json_config: pathlib.Path
):
config_files = config.find_config_files(path=str(config_path))
config_files = config.find_config_files(path=config_path)

assert yaml_config in config_files
assert json_config in config_files
Expand Down
20 changes: 11 additions & 9 deletions tests/test_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,14 @@ def test_updating_remote(
repo_dict = filter_repos([config], name="myclone")[0]
repo = update_repo(repo_dict)
for remote_name, remote_info in repo.remotes().items():
current_remote_url = repo.remote(remote_name).fetch_url.replace("git+", "")
if remote_name in config["remotes"]:
assert (
config["remotes"][remote_name].fetch_url.replace("git+", "")
== current_remote_url
)

elif remote_name == "origin":
assert config["url"].replace("git+", "") == current_remote_url
remote = repo.remote(remote_name)
if remote is not None:
current_remote_url = remote.fetch_url.replace("git+", "")
if remote_name in config["remotes"]:
assert (
config["remotes"][remote_name].fetch_url.replace("git+", "")
== current_remote_url
)

elif remote_name == "origin":
assert config["url"].replace("git+", "") == current_remote_url
0