8000 Decouple regexes, make varaibles consistent by tony · Pull Request #463 · vcs-python/libvcs · GitHub
[go: up one dir, main page]
Skip to content

Decouple regexes, make varaibles consistent #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Decouple regexes, make varaibles consistent #463

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e877d3
url: Decouple user regex to `RE_USER`
tony Jun 17, 2024
1366a7a
constants(SCP_REGEX): `SCP_REGEX` to constants module
tony Jun 17, 2024
2be09ba
constants(RE_SCP): `SCP_REGEX` -> `RE_SCP`
tony Jun 17, 2024
4fbf8a1
constants(RE_PIP_REV): git -> constants
tony Jun 17, 2024
822f2d4
docs(constants): Document libvcs.url constants
tony Jun 17, 2024
080ece7
docs(CHANGES): Note regex updates to libvcs.url'
tony Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(CHANGES): Note regex updates to libvcs.url'
  • Loading branch information
@tony
tony committed Jun 17, 2024
commit 080ece767c762657c1ad6e61e09c9b4728dbbe31
11 changes: 11 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ $ pip install --user --upgrade --pre libvcs

<!-- Maintainers, insert changes / features for the next release here -->

### Breaking changes

#### urls: Variable changes (#463)

- `RE_PIP_REV` moved from `libvcs.url.git` to `libvcs.url.constants`.
- Regex pattern for user (e.g. `git@`) decoupled to `RE_USER`.
- `RE_PATH` and `SCP_REGEX` (now `RE_SCP`) no longer include user regex pattern
- Existing patterns now use `RE_USER` explicitly.
- `REGEX_SCP` renamed to `RE_SCP` for consistency.

### Documentation

- Automatically linkify links that were previously only text.
Expand All @@ -26,6 +36,7 @@ $ pip install --user --upgrade --pre libvcs
- poetry: 1.8.1 -> 1.8.2

See also: https://github.com/python-poetry/poetry/blob/1.8.2/CHANGELOG.md

- Code quality: Use f-strings in more places (#460)

via [ruff 0.4.2](https://github.com/astral-sh/ruff/blob/v0.4.2/CHANGELOG.md).
Expand Down
0