8000 `url`: Improvements to parsing URLs by tony · Pull Request #423 · vcs-python/libvcs · GitHub
[go: up one dir, main page]
Skip to content

url: Improvements to parsing URLs #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 25, 2022
Merged

url: Improvements to parsing URLs #423

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6da55a
fix(URLProtocol): Use classmethod for is_valid
tony Sep 24, 2022
5799245
refactor(url[git]): De-duplicate code in GitURL
tony Sep 24, 2022
accc010
chore(url[git]): Always fetch colon separator in scp-URLs
tony Sep 24, 2022
7908a83
refactor(url[hg]): Add HgBaseURL, HgPipURL, update tests
tony Sep 24, 2022
03602f4
fix(url[svn]): Fix svn to be None by default
tony Sep 24, 2022
d4a03b9
feat(url): Add is_explicit for is_valid on Svn and Mercurial
tony Sep 24, 2022
1d0fb50
refactor!(url[svn]): Examples and further parsing tests
tony Sep 25, 2022
cd9bb0a
docs(CHANGES): Note url updates
tony Sep 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(url): Add is_explicit for is_valid on Svn and Mercurial
  • Loading branch information
@tony
tony committed Sep 25, 2022
commit d4a03b965e395799273de0c39c09c9bd4c4cfe97
6 changes: 6 additions & 0 deletions src/libvcs/url/hg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,12 @@ def is_valid(cls, url: str, is_explicit: Optional[bool] = None) -> bool:
>>> HgBaseURL.is_valid(url='notaurl')
False
"""
if is_explicit is not None:
return any(
re.search(rule.pattern, url)
for rule in cls.rule_map.values()
if rule.is_explicit == is_explicit
)
return any(re.search(rule.pattern, url) for rule in cls.rule_map.values())

def to_url(self) -> str:
Expand Down
6 changes: 6 additions & 0 deletions src/libvcs/url/svn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ def is_valid(cls, url: str, is_explicit: Optional[bool] = None) -> bool:
>>> SvnURL.is_valid(url='notaurl')
False
"""
if is_explicit is not None:
return any(
re.search(rule.pattern, url)
for rule in cls.rule_map.values()
if rule.is_explicit == is_explicit
)
return any(re.search(rule.pattern, url) for rule in cls.rule_map.values())

def to_url(self) -> str:
Expand Down
0