Open
Conversation
Tests on other PRs are failing with the following error:
Error: Requested Erlang/OTP version (23) not found in version list (should you be using option 'version-type': 'strict'?)
I tried changing the Ubuntu version used in the CI environment based on
Googling for ideas, and it seems to get the tests running.
Starting with Ranch 2.0, you get a warning when mixing Ranch and TCP socket options in a single keyword list. We only support the old syntax, so you'll get warnings at startup, and presumably that syntax will stop working at some point. This diff adds support for the new syntax. It does so in a backwards compatible way, so you can upgrade Ranch and your option syntax either before or after upgrading elixir-thrift.
This reverts commit 6ebbdcd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.