8000 install: implement option -C by sylvestre · Pull Request #8265 · uutils/coreutils · GitHub
[go: up one dir, main page]
Skip to content

install: implement option -C #8265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

install: implement option -C #8265

wants to merge 2 commits into from
+227 −8

Conversation

sylvestre
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-C is no longer failing!

@cakebaker
Copy link
Contributor

I don't know if you have seen it: test_install_compare_special_mode_bits fails on FreeBSD:

thread 'test_install::test_install_compare_special_mode_bits' panicked at tests/by-util/test_install.rs:1716:10:
      Command was expected to succeed. code: 1
      stdout = removed 'dest_file'
  
       stderr = install: dest_file: chmod failed with error Inappropriate file type or format (os error 79)
      install: failed to chmod 'dest_file'

cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
src/uu/install/src/install.rs
/// Check if a file needs to be copied due to ownership differences when no explicit group is specified.
/// Returns true if the destination file's ownership would differ from what it should be after installation.
#[cfg(not(target_os = "windows"))]
fn needs_copy_for_ownership(to: &Path, to_meta: &fs::Metadata) -> UResult<bool> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for returning UResult<bool> instead of just bool?

cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
@sylvestre @cakebaker
simplify the code
74b5299 
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/install/install-C is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker
0