8000 Fix the last two GNU tests for fmt by sylvestre · Pull Request #8264 · uutils/coreutils · GitHub
[go: up one dir, main page]
Skip to content

Fix the last two GNU tests for fmt #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix the last two GNU tests for fmt #8264

wants to merge 2 commits into from
+91 −10

Conversation

sylvestre
Copy link
Contributor

No description provided.

@sylvestre sylvestre changed the title Fix fmt Fix the last two GNU tests for fmt Jun 24, 2025
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/fmt/goal-option is no longer failing!

< 8000 /div>
cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
tests/by-util/test_fmt.rs
#[test]
fn test_fmt_unicode_whitespace_handling() {
// Test that Unicode whitespace characters like non-breaking space are NOT treated as whitespace
// This prevents regression of the character classification fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what "character classification fix" refers to.

cakebaker
cakebaker reviewed Jun 25, 2025
View reviewed changes
tests/by-util/test_fmt.rs
#[test]
fn test_fmt_knuth_plass_line_breaking() {
// Test the Knuth-Plass optimal line breaking algorithm behavior
// This prevents regression of the line breaking algorithm improvements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what "line breaking algorithm improvements" refers to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker
0