l10n: port stat for translation + use thiserror + add french #8243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- I had to update the logic to handle french accents (and other chars)
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 25, 2025
cakebaker
reviewed
Jun 25, 2025
src/uu/stat/src/stat.rs
Outdated
Comment on lines
178
to
180
| /// Scans for a number at the beginning of the string | ||
| /// Returns the parsed number and the character count (not byte count) | ||
| /// This was updated to properly handle UTF-8 by tracking both character and byte counts |
There was a problem hiding this comment.
I thought a bit more about the changes made to this function and somehow it doesn't make much sense to have both character and byte counts. We only deal with ASCII characters (+, -, and 0 - 9) and thus character count and byte count are the same.
There was a problem hiding this comment.
yeah, good point!
cakebaker
reviewed
Jun 25, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 26, 2025
Comment on lines
-152
to
-164
| let mut i = 0; | ||
| let mut count = 0; | ||
|
|
||
| match chars.next() { | ||
| Some('-' | '+' | '0'..='9') => i += 1, | ||
| Some('-' | '+' | '0'..='9') => { | ||
| count += 1; | ||
| } | ||
| _ => return None, | ||
| } | ||
| for c in chars { | ||
| match c { | ||
| '0'..='9' => i += 1, | ||
| _ => break, | ||
| } | ||
|
|
||
| for _ in chars.take_while(char::is_ascii_digit) { | ||
| count += 1; | ||
| } | ||
| if i > 0 { | ||
| F::from_str(&self[..i]).ok().map(|x| (x, i)) |
There was a problem hiding this comment.
I think you can simplify it with something like:
let count = chars
.next()
.filter(|&c| c.is_ascii_digit() || c == '-' || c == '+')
.map(|_| 1 + chars.take_while(char::is_ascii_digit).count())
.unwrap_or(0);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.