8000 unexpand: add -f short alias for --first-only by GTimothy · Pull Request #8229 · uutils/coreutils · GitHub
[go: up one dir, main page]
Skip to content

unexpand: add -f short alias for --first-only #8229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2025
Merged

unexpand: add -f short alias for --first-only #8229

merged 2 commits into from
Jun 19, 2025

Conversation

GTimothy
Copy link
Contributor
@GTimothy GTimothy commented Jun 19, 2025 •
edited
Loading

Changes:

  • a one line change adds the --first-only alias -f expected by busybox
  • documentation of this alias which is an extension to the GNU reference.

It reduces test failures for make UTILS=unexpand busytest from 7 to 2.

@sylvestre
Copy link
Contributor

could you please add a test to make sure we don't regress ?

and document this diff
https://github.com/uutils/coreutils/blob/main/docs/src/extensions.md

@GTimothy
Copy link
Contributor Author
GTimothy commented Jun 19, 2025 •
edited
Loading

Ok, will document the diff.
As for the test, how would I test this more than the already busytest test ?

@GTimothy GTimothy force-pushed the busybox-first-only-alias branch from ad42181 to ce0c2af Compare June 19, 2025 13:21
@GTimothy
Copy link
Contributor Author

the gnu test misc/unexpand.pl still passes with this change.

@sylvestre
Copy link
Contributor

yes, we want tests in the rust testsuite as they are easy to run and run quickly

sylvestre
sylvestre reviewed Jun 19, 2025
View reviewed changes
GTimothy and others added 2 commits June 19, 2025 19:53
@GTimothy @sylvestre
unexpand: add -f short alias for --first-only
4655888 
add the `--first-only` alias `-f` expected by busybox.
document the change.

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@GTimothy
unexpand: add test for -f alias
2fa89ca 
add two tests for the `-f` alias
@GTimothy GTimothy force-pushed the busybox-first-only-alias branch from 6fe2011 to 2fa89ca Compare June 19, 2025 17:55
@GTimothy
Copy link
Contributor Author
GTimothy commented Jun 19, 2025 •
edited
Loading

@sylvestre Currently it is split in two commits. Should I merge them into one (if the tests are ok) ?

@sylvestre
Copy link
Contributor

don't bother :)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit d05460a into uutils:main Jun 19, 2025
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. 5ED4 Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GTimothy @sylvestre
0