8000 ls: follow symlinks for xattrs, fix #8216 by sudhackar · Pull Request #8217 · uutils/coreutils · GitHub
[go: up one dir, main page]
Skip to content

ls: follow symlinks for xattrs, fix #8216 #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 19, 2025
Merged

ls: follow symlinks for xattrs, fix #8216 #8217

merged 7 commits into from
Jun 19, 2025

Conversation

sudhackar
Copy link
Contributor 
$ strace -e llistxattr,listxattr,getxattr ./target/debug/coreutils ls -lLd l
listxattr("l", 0x1, 0)                  = 24
listxattr("l", "system.posix_acl_access\0", 24) = 24
drwxrwxr-x+ 2 sudhackar sudhackar 4096 Jun 18 16:47 l
+++ exited with 0 +++

as compared to no +

@sudhackar
ls: follow symlinks for xattrs
d5450d7 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
Copy link
Contributor Author

This should fix #8216

sudhackar added 2 commits June 18, 2025 18:55
@sudhackar
ls: clippy, fix ref
3175a33 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: tests, fix spell
bae7a49 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@cakebaker cakebaker linked an issue Jun 18, 2025 that may be closed by this pull request
ls: doesn't list acl "+" status for symlinks #8216
Closed
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

cakebaker
cakebaker reviewed Jun 18, 2025
View reviewed changes
sudhackar added 3 commits June 19, 2025 10:15
@sudhackar
ls: tests, fix path
3d9e6a1 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: tests, fix regex for MinRustV
b337509 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
ls: gnu tests, use listxattr instead of llistxattr
5edc3ae 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@sudhackar
Copy link
Contributor Author

I have fixed the patch for the GNU test - that passes now instead of SKIP

@sudhackar
ls: gnu tests, fix spell
bf48ee7 
Signed-off-by: Sudhakar Verma <sudhakar.verma@canonical.com>
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sudhackar
Copy link
Contributor Author

tests/misc/tee seems flaky locally - failed 1 out of 10 runs for me

@sylvestre
Copy link
Contributor

we know, just ignore it :)

@sylvestre
Copy link
Contributor

(but don't hesitate to have a look to fix it if you can reproduce it easily :)

@sylvestre sylvestre merged commit c674cf1 into uutils:main Jun 19, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ls: doesn't list acl "+" status for symlinks
3 participants
@sudhackar @sylvestre @cakebaker
0