8000 timeout: catch TERM signal by Luv-Ray · Pull Request #8197 · uutils/coreutils · GitHub
[go: up one dir, main page]
Skip to content

timeout: catch TERM signal #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

timeout: catch TERM signal #8197

wants to merge 4 commits into from

Conversation

Luv-Ray
Copy link
Contributor
@Luv-Ray Luv-Ray commented Jun 16, 2025

fixes #8040
set a signal handler and terminate child process on receiving SIGTERM.
I'm a bit confused about how to write tests for it, is it appropriate to use ps and kill in ci?

@Luv-Ray Luv-Ray force-pushed the timeout_catch_sigterm branch from bb663cb to c354e53 Compare June 16, 2025 04:02
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@Ecordonnier
Copy link
Contributor

I have added a very similar test for sleep and SIGSEGV. You can probably write a very similar test.

@martinkunkel2
Copy link

@Luv-Ray : I tried to write a test. Feel free to integrate it to your pull request: martinkunkel2@e4591cd

@sylvestre
Copy link
Contributor

Looks like a good test too

@Luv-Ray
Copy link
Contributor Author
Luv-Ray commented Jun 22, 2025

@Luv-Ray : I tried to write a test. Feel free to integrate it to your pull request: martinkunkel2@e4591cd

Thank you so much ❤️

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@martinkunkel2
Copy link

@sylvestre could you please retrigger the CICD / Build (macos-13, x86_64-apple-darwin, feat_os_macos, true) (pull_request)? Looks like a sporadic issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeout: on receiving TERM signal, child process is not terminated
4 participants
@Luv-Ray @Ecordonnier @martinkunkel2 @sylvestre
0