tests/ts/kill/decode: avoid using shell built-in kill command #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case should do the same as other kill test cases, avoiding using shell built-in kill command. Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: c1c4084b2729e20e7620a805dee9d2cd452e5493) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: 65f88db5ed84491c787cca443eece416e2cecf5c) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: 65f88db5ed84491c787cca443eece416e2cecf5c) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: 65f88db5ed84491c787cca443eece416e2cecf5c) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
brainhoard-github
pushed a commit
to distro-core-curated-mirrors/poky-contrib
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: cc88f2136b8e5f8e18af3339c49024655aaebd04) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
brainhoard-github
pushed a commit
to distro-core-curated-mirrors/poky-contrib
that referenced
this pull request
May 16, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: 031fee7ae80dfc545ab588ebf2bc4e6081aa0029) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
brainhoard-github
pushed a commit
to distro-core-curated-mirrors/poky-contrib
that referenced
this pull request
May 17, 2025
License-Update: add EUPL-1.2. See util-linux/util-linux@74f3265 The run-ptest script is changed to use --builddir. This is because util-linux upstream does not have much priority on testing the --use-system-commands option. For example, with --use-system-commands, we have two failed test cases: kill/decode and lsfd/mkfds-foreign-sockets. With --builddir, all test cases succeed. I created PR for the kill/decode issue: util-linux/util-linux#3571. The root cause is obvious for kill/decode. But the root cause for lsfd/mkfds-foreign-sockets is not obvious, at least to me. So instead of spending time fixing test case issues for --use-system-commands, we'd better just use --builddir. (From OE-Core rev: 031fee7ae80dfc545ab588ebf2bc4e6081aa0029) Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case should do the same as other kill test cases, avoiding using shell built-in kill command.